This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Add ability to register custom services to Authom #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 6, 2012 10:49
…services without having to place them into the /lib folder inside the authom module. Useful for local business-domain auth services that wouldn't be suited for a pull in authom's core. (For example a company specific in-house login/password system.)
|
+1 to this. Seems like a more efficient way to allow people to add services. I would almost like to see all the 'services' registered in this way. |
|
@jed Is there something we can do to improve this PR to get it accepted? Or are you against the idea outright? |
jed
added a commit
that referenced
this pull request
Nov 8, 2012
Add ability to register custom services to Authom
|
it's a good idea, just fell through the cracks. merged, about to update npm. |
|
Thanks Jed! Sent from my iPhone On 2012-11-07, at 10:00 PM, Jed Schmidt notifications@github.com wrote: it's a good idea, just fell through the cracks. merged, about to update npm. — |
|
don't thank me, thank @ovaillancourt! |
|
haha, well thanks jed anyways! Man I had completely forgot about that pull too. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull adds the
registerServicemethod that allows someone to register an authom-compatible service that is too specific to go into the core services folder. (For example a business-specific login/pass system.)This also allows to override the behavior of existing "core" services.
Also added documentation + usage example.